fix(shared): make UrlElicitationRequiredError pickle-safe - #3262
Open
ulofiai wants to merge 2 commits into
Open
Conversation
Signed-off-by: ulofiai <[email protected]>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Signed-off-by: ulofiai <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2431.
The constructor shape reported for
McpErrorno longer exists onmain:MCPErrornow stores(code, message, data)inException.args, so the base class already survives pickle round-trips.UrlElicitationRequiredErrorstill inherits those arguments even though its constructor accepts(elicitations, message=None), causing bothpickleandcloudpickleto call it with the wrong arity during unpickling.Add an explicit
__reduce__that reconstructs the subclass through its original constructor signature. This preserves the exception type, message, structured error payload, and typed elicitation list. Add regression coverage for both the baseMCPErrorcontract and the URL-elicitation subclass.Tests:
tests/shared/test_exceptions.py(12 passed)pickleandcloudpickle==3.1.2round-trips